-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/gofiber: add gofiber trace propagation #1487
Conversation
I'm running into an issue where APM doesn't connect services because fiber doesn't read the request headers for the distributed span ID. This PR would fix that. I think this also would have partially addressed this issue: #1222 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mckeown-dd, thanks for the contribution, can you add a unit test?
@ahmed-mez. Can you help me figure out why the lint test is failing? Looks like there was already a unit test for propagation, but it didn't really catch the issue. I modified it to check that the trace id is the same as the parent if one is passed. |
It's your imports list, we enforce a style guide on the grouping and ordering of them as defined here: https://github.com/DataDog/dd-trace-go/wiki/Style-guidelines#imports It should be a nice quick and easy fix :) |
This comment has been minimized.
This comment has been minimized.
8f26753
to
39b6003
Compare
BenchmarksFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases. |
This updates gofiber to the earliest version that gave a map for go fiber's request headers. It iterates through those, creates a http.Header object so that the tracer extraction process doesn't have to be modified.